#Saltstack change minion name update
#Saltstack change minion name Patch
#Saltstack change minion name upgrade
#Saltstack change minion name code

Let’s implement exactly that!įor example, there is an issue #54755 ( pip failures even when not using pip) that badly affected Salt 2019.2.1.

#Saltstack change minion name update

Then any upgrades would lead to a loud failure, and you won’t forget to remove or update the patched module. It would be nice if a patched module just stopped working with any Salt version that doesn’t match the target one. Also, direct imports could potentially have unintended side effects.ĬAVEAT: your custom delete function will be silently ignored (even with a version-aware guard) if the upstream sqlite3.py module gets its own delete function (i.e., after a Salt upgrade).

#Saltstack change minion name code

It works! Please note, that because the overlay module is named differently than the original one, all that initialization code in the upstream module is still triggered. % sudo salt minion1 sdb.get sdb://mysqlite/password For more complex conflicts, you’ll need to spend some time to port the patch.īy comparing the original salt-2019.2.3 tree with the patched one (using the diff -Naur -x '*.orig' -x '*.rej' salt-2019.2.3) conn.

#Saltstack change minion name Patch

The patch won’t apply cleanly however, if you inspect the salt/modules/pip.py.rej and salt/states/pip_state.py.rej, you’ll see that they contain non-functional changes and could be ignored. You can see the resulting patch here: pip-extra-args-orig.diff Let’s say you want to backport the ability to pass arbitrary pip arguments through pip.installed from Neon to 2019.2.3 (PR #52327).Ī simple way to extract the feature is to open the link, download the patch and remove unnecessary hunks/files that are related to tests and docs. In all other cases, it is much safer to extract a specific patch and adapt it to apply cleanly to your specific Salt version. The only scenario when it’ll likely end up well is when a module doesn’t exist yet in your Salt version and doesn’t depend on any other modules. The general advice is to avoid grabbing the latest modules from the upstream Git repo and putting them into your salt:// file tree. Or individually via the saltutil.sync_* runner commands.Īlso, custom modules are automatically synced whenever a highstate is performed. Fortunately, SaltStack has a built-in way to patch itself! If you have a large or constantly evolving patchset, you’ll keep yourself sane by making your own fork and installing it via pip or custom packages.Īs a DevOps engineer, you need to fix problems quickly. The methods described are mostly suitable for applying a couple of simple fixes. Some of the ways are hacky, but bugs are bugs, and you need to fix them in the most efficient way. Fortunately, SaltStack has a built-in way to patch itself! After reading this guide, you’ll be able to patch almost any part of Salt code, even if you run multiple versions simultaneously. Or maybe you were wrongly expecting that your PR against the master branch would be included in the nearest release but were told that the upcoming release is feature frozen, and you have to wait another 4 months for the next one.Īs a DevOps engineer, you need to get things done quickly.

#Saltstack change minion name upgrade

Even if it was released, maybe you can’t yet upgrade Salt across the whole minion fleet. Or a cool feature that you badly need has landed in the old develop branch and is waiting forever to be migrated to the new master. You should see an event like the following: salt/beacon/salt-minion/inotify//etc/nginx/nginx.Let’s say you were bitten by a critical bug in Salt (2019.2.0 & 2019.2.1 were painful for many of us) that had an existing but unreleased fix. On your Salt minion, make a change to your nf file, and then check out your Salt event runner shell.

You will use this to monitor for file change events from your beacon. Open another shell to your Salt master and start the Salt event runner.

Base : '*' : - nginx_conf - packages - beaconsĪpply a highstate from your Salt master to implement these changes on your minions: salt '*' state.apply